Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

519 policy api updates #538

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

519 policy api updates #538

wants to merge 2 commits into from

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Dec 23, 2024

🗣 Description

Google released more settings in the Policy API subsequent to the initial PR for the ScubaGoggles Policy API integration. The settings have allowed the following policies to be implemented as part of this PR:

  • Common Controls 1.1: Phishing-Resistant MFA SHALL be required for all users
  • Common Controls 1.2: Google 2SV new user enrollment period SHALL be set to 1 week
  • Common Controls 1.3: Allow users to trust the device SHALL be disabled
  • Common Controls 16.2: User access to Early Access Apps SHOULD be disabled
  • Gmail 1.1: Mail Delegation SHOULD be disabled
  • Gmail 8.1: User email uploads SHALL be disabled to protect against unauthorized files being introduced into the secured environment
  • Gmail 9.1: POP and IMAP access SHALL be disabled to protect sensitive agency or organization emails from being accessed through legacy applications or other third-party mail clients
  • Gmail 10.1: Google Workspace Sync SHOULD be disabled
  • Gmail 12.1: Using a per-user outbound gateway that is a mail server other than the Google Workspace mail servers SHALL be disabled

Closes #519

🧪 Testing

Rego tests were added for the new implementations detailed above. They all include testing for the
compliant and non-compliant cases. The following test files have been added:

commoncontrols_api01_test.rego
commoncontrols_api04_test.rego
commoncontrols_api16_test.rego
gmail_api01_test.rego
gmail_api08_test.rego
gmail_api09_test.rego
gmail_api10_test.rego
gmail_api12_test.rego

In addition to these tests, testing was done on each affected baseline using the scubagws Admin UI .

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev linked an issue Dec 23, 2024 that may be closed by this pull request
2 tasks
@rlxdev rlxdev changed the base branch from main to 518-policy-api-GA-url January 9, 2025 18:05
@prodjom prodjom marked this pull request as ready for review January 9, 2025 19:36
@rlxdev rlxdev force-pushed the 518-policy-api-GA-url branch from 864469b to 8715985 Compare January 9, 2025 20:36
@rlxdev rlxdev force-pushed the 519-policy-api-updates branch from 484e88d to 67abc58 Compare January 9, 2025 20:36
@rlxdev rlxdev changed the base branch from 518-policy-api-GA-url to main January 9, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tool to include the additional data received from the API
1 participant